Merged
Conversation
blake
added
type/enhancement
blake
requested review from
curtbushko and
jmurret
and removed request for
a team
jmurret
approved these changes
Jul 17, 2023
blake
force-pushed
the
blake/enable-websocket-connection-upgrades
branch
from
405fc1c to
c918e54
Compare
Contributor
|
Looks like this PR is stuck in CI and still has some conflicts it seems. Looking forward to seeing this merged. |
hashi-derek
approved these changes
Jul 17, 2023
blake
force-pushed
the
blake/enable-websocket-connection-upgrades
branch
from
c918e54 to
900d6f1
Compare
This PR explicitly enables WebSocket upgrades in Envoy's UpgradeConfig for all proxy types. (API Gateway, Ingress, and Sidecar.) Fixes #8283
blake
force-pushed
the
blake/enable-websocket-connection-upgrades
branch
from
900d6f1 to
b8dd99b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explicitly enable WebSocket connection upgrades in Envoy's HTTP connection manager. This is required to enable mesh applications configured with the
httpprotocol to receive WebSocket connection upgrade requests from HTTP clients.Links
Resolves #8283.
PR Checklist